Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI actions and generate Javadoc on JDK 21 #1439

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Update CI actions and generate Javadoc on JDK 21 #1439

merged 8 commits into from
Sep 12, 2024

Conversation

msridhar
Copy link
Member

@msridhar msridhar commented Sep 12, 2024 •
edited
Loading

This keeps us up to date and also moves us off of some deprecated Gradle-related actions.

We also generate Javadoc on a more recent JDK version to get latest Javadoc improvements.

@msridhar msridhar changed the title Bump versions of various CI actions Bump versions of various CI actions and generate Javadoc on JDK 22 Sep 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Test Results

  813 files  ±0    813 suites  ±0   4h 17m 46s ⏱️ + 19m 24s
  735 tests ±0    718 ✅ ±0   17 💤 ±0  0 ❌ ±0 
5 029 runs  ±0  4 908 ✅ ±0  121 💤 ±0  0 ❌ ±0 

Results for commit 60d9613. ± Comparison against base commit 53cf8f0.

♻️ This comment has been updated with latest results.

@msridhar msridhar changed the title Bump versions of various CI actions and generate Javadoc on JDK 22 [WIP] Bump versions of various CI actions and generate Javadoc on JDK 22 Sep 12, 2024
@msridhar msridhar marked this pull request as draft September 12, 2024 17:01
liblit
liblit previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@liblit liblit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me in principle, though our automated tests disagree. I’ll re-review once the tests are passing.

@msridhar msridhar changed the title [WIP] Bump versions of various CI actions and generate Javadoc on JDK 22 Update CI actions and generate Javadoc on JDK 22 Sep 12, 2024
@msridhar
Copy link
Member Author

@liblit I think this is ready for another look

@msridhar msridhar marked this pull request as ready for review September 12, 2024 21:22
@msridhar msridhar changed the title Update CI actions and generate Javadoc on JDK 22 Update CI actions and generate Javadoc on JDK 21 Sep 12, 2024
@msridhar msridhar merged commit 6367ec6 into wala:master Sep 12, 2024
11 checks passed
@msridhar msridhar deleted the bump-actions branch September 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liblit liblit liblit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msridhar @liblit